Skip to content

p11-kit: Appropriately update to 0.26.5 - #33925

Merged
reneeotten merged 1 commit into
macports:masterfrom
commitmaniac:feat/p11-kit-0.26.5
Aug 9, 2026
Merged

p11-kit: Appropriately update to 0.26.5#33925
reneeotten merged 1 commit into
macports:masterfrom
commitmaniac:feat/p11-kit-0.26.5

Conversation

@commitmaniac

@commitmaniac commitmaniac commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Originally, this pull request updated p11-kit to 0.26.5. However, 1037319 was rudely pushed. Manually include shell completions since the autotools build system is outdated (and likely to be deprecated over meson).

Tested on

macOS 10.7.5 11G63 x86_64
Xcode 4.6.3 4H1503

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vd install?
  • tested basic functionality of all binary files?

@commitmaniac

commitmaniac commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@barracuda156 Kindly confirm if Trac#73614 and Trac#70399 are still applicable given this update, if you can.

From previous comments on each ticket, it appears that gcc-15 works just fine (which appears to be common with PPC support), and you have changed the port locally to use a C11 compiler instead.

@barracuda156

Copy link
Copy Markdown
Contributor

Type redefinition is C11 feature, so it will not compile with Xcode gcc.

@commitmaniac
commitmaniac force-pushed the feat/p11-kit-0.26.5 branch 2 times, most recently from 737cfc9 to 0e60f41 Compare August 7, 2026 05:17
@commitmaniac commitmaniac changed the title p11-kit: Update to 0.26.5 p11-kit: Appropriately update to 0.26.5 Aug 7, 2026
@pmetzger

pmetzger commented Aug 7, 2026

Copy link
Copy Markdown
Member

Why should we care about xcode gcc?

@barracuda156

Copy link
Copy Markdown
Contributor

Why should we care about xcode gcc?

You don’t have to. Others can decide for themselves.
The point, however, is that the port needs C11, whether you care about it or not.

@pmetzger

pmetzger commented Aug 7, 2026

Copy link
Copy Markdown
Member

The point I'm making is this: your claim, consistently, has been that you don't delay people with your requests that they support Macs that have been out of support for 20+ years. However, you consistently chime in on pull requests as though people are obligated to do so.

@commitmaniac

commitmaniac commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Why should we care about xcode gcc?

@pmetzger MacPorts might not care about Xcode GCC, but they should care about ports using the right compiler. A compromise to avoid this perceived "Atlas-like" burden exists in other ports as well, too; this might do.

compiler.blacklist-append    *gcc-4.* {clang < 300}

Comment thread security/p11-kit/Portfile
@barracuda156

Copy link
Copy Markdown
Contributor

@pmetzger Perry, did you have a bad day? I was explicitly asked about two tickets (which are not even mine). I explained why C11 is the requirement and confirmed that it remains relevant. What’s you problem with this? How not adding C11 (a standard MacPorts convention, not some per-port hack) makes a PR to get in faster?

@pmetzger

pmetzger commented Aug 8, 2026

Copy link
Copy Markdown
Member

A compromise to avoid this perceived "Atlas-like" burden exists in other ports as well, too; this might do.

Yes, blacklisting old compilers is fine. I have no problem with that.

@reneeotten

Copy link
Copy Markdown
Contributor

I don't think anything else needs to be done for this right? Setting the correct compiler.c_standard is of course correct and there is no manual blacklisting needed anymore - correct?

@barracuda156

Copy link
Copy Markdown
Contributor

@reneeotten AFAIK, yes. No need for any specific fixes for older OS, c_standard does the job.

@commitmaniac
commitmaniac requested a review from reneeotten August 9, 2026 03:33
@reneeotten
reneeotten merged commit 1b31097 into macports:master Aug 9, 2026
3 checks passed
@commitmaniac
commitmaniac deleted the feat/p11-kit-0.26.5 branch August 10, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants