p11-kit: Appropriately update to 0.26.5 - #33925
Conversation
|
@barracuda156 Kindly confirm if Trac#73614 and Trac#70399 are still applicable given this update, if you can. From previous comments on each ticket, it appears that gcc-15 works just fine (which appears to be common with PPC support), and you have changed the port locally to use a C11 compiler instead. |
|
Type redefinition is C11 feature, so it will not compile with Xcode gcc. |
737cfc9 to
0e60f41
Compare
0e60f41 to
482a33d
Compare
|
Why should we care about xcode gcc? |
You don’t have to. Others can decide for themselves. |
|
The point I'm making is this: your claim, consistently, has been that you don't delay people with your requests that they support Macs that have been out of support for 20+ years. However, you consistently chime in on pull requests as though people are obligated to do so. |
@pmetzger MacPorts might not care about Xcode GCC, but they should care about ports using the right compiler. A compromise to avoid this perceived "Atlas-like" burden exists in other ports as well, too; this might do. |
|
@pmetzger Perry, did you have a bad day? I was explicitly asked about two tickets (which are not even mine). I explained why C11 is the requirement and confirmed that it remains relevant. What’s you problem with this? How not adding C11 (a standard MacPorts convention, not some per-port hack) makes a PR to get in faster? |
Yes, blacklisting old compilers is fine. I have no problem with that. |
|
I don't think anything else needs to be done for this right? Setting the correct compiler.c_standard is of course correct and there is no manual blacklisting needed anymore - correct? |
|
@reneeotten AFAIK, yes. No need for any specific fixes for older OS, c_standard does the job. |
482a33d to
ec4f059
Compare
Description
Originally, this pull request updated p11-kit to 0.26.5. However, 1037319 was rudely pushed. Manually include shell completions since the autotools build system is outdated (and likely to be deprecated over meson).
Tested on
macOS 10.7.5 11G63 x86_64
Xcode 4.6.3 4H1503
Verification
Have you
port lint?sudo port test?sudo port -vd install?