Fix logger NameError in load_rules and expand test coverage - #16
Merged
Conversation
Fix a NameError in load_rules where `logger.critical` was called but only the `logging` module was imported (no named logger defined). This would crash at runtime whenever load_rules was given a nonexistent directory. Add 25 new unit tests covering previously untested code paths: - normalize_to_list utility function - load_config defaults (watch_rules, watch_interval) and YAML parse errors - load_rules with nonexistent directory and malformed YAML files - RuleValidator: header presence-only check, EOL Z-suffix format, EOL invalid format, EOL as datetime object (tz-aware and tz-naive), source_ip with no client_address, multiple CIDR OR logic - RuleFileMonitor: nonexistent directory, get_changed_rule_files directly, reload error handling preserving existing rules on duplicate URI conflict Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a NameError in load_rules where
logger.criticalwas called but only theloggingmodule was imported (no named logger defined). This would crash at runtime whenever load_rules was given a nonexistent directory.Add 25 new unit tests covering previously untested code paths: