Skip to content

cast flag bitmask to bool to prevent 8's from showing up where I would expect a 1 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjsmith1999 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cast flag bitmask to bool to prevent 8's from showing up where I would expect a 1 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/MCP2515.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ CAN_FRAME MCP2515::ReadBuffer(uint8_t buffer) {
uint8_t byte4 = SPI.transfer(0x00); // RXBnEID0
uint8_t byte5 = SPI.transfer(0x00); // RXBnDLC

message.extended = (byte2 & B00001000);
message.extended = bool(byte2 & B00001000);

if(message.extended) {
message.id = (byte1>>3);
Expand All @@ -441,7 +441,7 @@ CAN_FRAME MCP2515::ReadBuffer(uint8_t buffer) {
message.id = ((byte1>>5)<<8) | ((byte1<<3) | (byte2>>5));
}

message.rtr=(byte5 & B01000000);
message.rtr=bool(byte5 & B01000000);
message.length = (byte5 & B00001111); // Number of data bytes
for(int i=0; i<message.length; i++) {
message.data.byte[i] = SPI.transfer(0x00);
Expand Down