fix(stella-core): drop the duplicate Mutex import two unbreak PRs both added - #3290
Closed
macanderson wants to merge 1 commit into
Closed
fix(stella-core): drop the duplicate Mutex import two unbreak PRs both added#3290macanderson wants to merge 1 commit into
macanderson wants to merge 1 commit into
Conversation
…h added #3263 and #3265 diagnosed the same red main independently and landed the same repair. Both added `use std::sync::Mutex;` to restore.rs's test module, at different lines, so git merged both and `stella-core` stopped compiling again — E0252, `Mutex` is defined multiple times. Removes the second one. The rest of the two repairs converged on identical text (both pointed the starvation witnesses at `SkillTools`), so this import is the whole delta. Keeps the placement #3263 chose, since it landed first.
Contributor
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves a duplicated Mutex import in stella-core's restore driver tests that was introduced by two overlapping fixes, restoring compilation without changing behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red again ateb427c2da. One line fixes it.What happened
Two PRs diagnosed the same red main independently and shipped the same repair:
fix(stella-core): repair main — the tool purge and #3253 composed into a red build(76ad90621)fix(stella-core): unbreak main — restore.rs references a test double #3244 deleted(678f41c27)Mine was #3265. I checked for an in-flight fix before starting (
gh pr listfiltered on restore/fix/compile) and found none — #3263 was opened after that check and merged before mine, so by the time #3265 landed the repair was already in. The two edits sit at different lines, so git had no conflict to report and merged both.The rest of the two repairs converged on byte-identical text — both pointed #3253's starvation witnesses at
SkillToolsand both removed the orphanedToolCall/ToolOutput/RESTORE_CALL_ID— so this duplicated import is the entire delta.The fix
Delete the second import. Keeps the placement #3263 chose, since it landed first.
Verify
No tests deleted or renamed. No behavior change.
Note
This is the second red main in a row out of the same file, and the two causes are different: #3267 tracks the first (a clean merge deleting a test helper another PR was concurrently using). This one is the duplicate-repair hazard — two agents racing the same breakage — which a merge queue would also have caught, and which is more evidence for option 1 in #3267.
Summary by Sourcery
Bug Fixes: