Skip to content

fix(stella-cli): drop imports left unused when the diagnostic impl moved out #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macanderson merged 1 commit into from
Aug 7, 2026
+8 −5
Merged

fix(stella-cli): drop imports left unused when the diagnostic impl moved out #2045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions crates/stella-cli/src/agent/tools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
//! ports.

use super::*;
use stella_pipeline::{
ArtifactIdentity, ArtifactKind, CmdKind, DiagnosticInvocation, DiagnosticRunner,
TestInvocation, TestRunner,
};
// `DiagnosticInvocation`/`DiagnosticRunner` are deliberately absent: the impl
// that used them moved to `super::diagnostics`, and only this file's tests
// still name them. They are imported per test module rather than here so a
// non-test build does not carry an unused import.
use stella_pipeline::{ArtifactIdentity, ArtifactKind, CmdKind, TestInvocation, TestRunner};

/// Apply the cross-crate policy shared by every model/repository-controlled
/// subprocess. Kept as a named seam so the CLI's pipeline-only spawns have a
Expand Down Expand Up @@ -848,6 +849,8 @@ mod tests {
atomic::{AtomicUsize, Ordering},
};

use stella_pipeline::{DiagnosticInvocation, DiagnosticRunner};

use stella_media::{
CostDecision, ImageRequest, MediaArtifact, MediaCapabilities, MediaError, MediaJob,
MediaJobStatus, MediaKind, MediaProvider, MediaSpendGate, MediaSpendRequest, VideoRequest,
Expand Down Expand Up @@ -1364,7 +1367,7 @@ mod benchmark_tests {
#[cfg(test)]
mod diff_baseline_tests {
use super::*;
use stella_pipeline::DiagnosticInvocation;
use stella_pipeline::{DiagnosticInvocation, DiagnosticRunner};

fn git(root: &std::path::Path, args: &[&str]) {
let ok = std::process::Command::new("git")
Expand Down