fix(gate): regenerate the file-size baseline — main is red on command_deck.rs - #2044
Merged
Conversation
…_deck.rs `main` fails `make file-size` at 6a41889: command_deck.rs is 4567 lines against its own baseline of 4566. Cause is the retightening skew, not a real growth. #2034 regenerated the baseline and ratcheted command_deck.rs down from 4621 to 4566, its size at that moment. A parallel PR that grew the file by one line was based on the 4621 entry, so its own gate was green, and both landed. `ci.yml` does not run on a push to main (#1986), so nothing reported it. Regenerated rather than hand-edited: the baseline is generated and gate-enforced, so it is the only copy that can stay correct. That also picks up deck_render.rs's earned ratchet-down (1531 -> 1529), which carries the same collision risk in the other direction — the mitigation is merging this quickly, not editing one line by hand.
Contributor
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRegenerates the file-size baseline to realign with current file lengths, fixing a failing size gate on command_deck.rs and incorporating an additional small ratchet-down for deck_render.rs, without changing any source files. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red.make file-sizefails at6a41889a:Every open PR inherits this, so it wants merging ahead of anything else.
Cause — retightening skew, not real growth
Nobody added 55 lines to
command_deck.rs. #2034 regenerated the baseline and ratcheted that entry down from 4621 to 4566 (its size at that moment). A parallel PR that grew the file by one line was written against the old 4621 entry, so its own gate was green. Both landed, and the sum is red.ci.ymldoes not run on a push tomain(#1986), so nothing reported it — the next PR to run the gate would have looked like the culprit.That retightening was mine, in #2034. Filing this rather than leaving it for whoever hits it next.
Fix
make file-size-update. Regenerated, not hand-edited: the baseline is generated and gate-enforced, so it is the only copy that can stay correct, and hand-editing one entry is how the last limit died.The regeneration also picks up
deck_render.rs's earned ratchet-down (1531 → 1529). That carries the same collision risk in the other direction, and there is no way to take the fix without it. The mitigation is merging this quickly rather than editing one line by hand — please do not let it sit.Verified
make file-size—OK — 1139 files, none over 1500 lines except 30 grandfathered (none grew).No source file changes; baseline only.
Summary by Sourcery
Build: