Skip to content

fix(gate): regenerate the file-size baseline — main is red on command_deck.rs - #2044

Merged
macanderson merged 1 commit into
mainfrom
unbreak-file-size-baseline
Aug 7, 2026
Merged

fix(gate): regenerate the file-size baseline — main is red on command_deck.rs#2044
macanderson merged 1 commit into
mainfrom
unbreak-file-size-baseline

Conversation

@macanderson

@macanderson macanderson commented Aug 7, 2026

Copy link
Copy Markdown
Owner

main is red. make file-size fails at 6a41889a:

crates/stella-cli/src/command_deck.rs grew to 4567 lines, over its baseline ceiling of 4566 (+1)

Every open PR inherits this, so it wants merging ahead of anything else.

Cause — retightening skew, not real growth

Nobody added 55 lines to command_deck.rs. #2034 regenerated the baseline and ratcheted that entry down from 4621 to 4566 (its size at that moment). A parallel PR that grew the file by one line was written against the old 4621 entry, so its own gate was green. Both landed, and the sum is red.

ci.yml does not run on a push to main (#1986), so nothing reported it — the next PR to run the gate would have looked like the culprit.

That retightening was mine, in #2034. Filing this rather than leaving it for whoever hits it next.

Fix

make file-size-update. Regenerated, not hand-edited: the baseline is generated and gate-enforced, so it is the only copy that can stay correct, and hand-editing one entry is how the last limit died.

The regeneration also picks up deck_render.rs's earned ratchet-down (1531 → 1529). That carries the same collision risk in the other direction, and there is no way to take the fix without it. The mitigation is merging this quickly rather than editing one line by hand — please do not let it sit.

Verified

make file-sizeOK — 1139 files, none over 1500 lines except 30 grandfathered (none grew).

No source file changes; baseline only.

Summary by Sourcery

Build:

  • Regenerate scripts/file-size-baseline.txt so the file-size check passes with the latest line counts.

…_deck.rs

`main` fails `make file-size` at 6a41889: command_deck.rs is 4567 lines
against its own baseline of 4566.

Cause is the retightening skew, not a real growth. #2034 regenerated the
baseline and ratcheted command_deck.rs down from 4621 to 4566, its size at
that moment. A parallel PR that grew the file by one line was based on the
4621 entry, so its own gate was green, and both landed. `ci.yml` does not run
on a push to main (#1986), so nothing reported it.

Regenerated rather than hand-edited: the baseline is generated and
gate-enforced, so it is the only copy that can stay correct. That also picks
up deck_render.rs's earned ratchet-down (1531 -> 1529), which carries the
same collision risk in the other direction — the mitigation is merging this
quickly, not editing one line by hand.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
stella-cli-docs Ignored Ignored Aug 7, 2026 4:55am

@sourcery-ai

sourcery-ai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Regenerates the file-size baseline to realign with current file lengths, fixing a failing size gate on command_deck.rs and incorporating an additional small ratchet-down for deck_render.rs, without changing any source files.

File-Level Changes

Change Details Files
Regenerate file-size baseline to match current sizes of grandfathered large files and restore green status for the file-size gate.
  • Recomputed file-size baselines using make file-size-update so that command_deck.rs’s recorded ceiling matches its current line count.
  • Captured the reduced size of deck_render.rs, lowering its stored baseline from 1531 to 1529 lines.
  • Updated scripts/file-size-baseline.txt as the single source of truth for size gating, with no changes to any Rust or source files.
scripts/file-size-baseline.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@macanderson
macanderson merged commit f0816ee into main Aug 7, 2026
14 of 15 checks passed
@macanderson
macanderson deleted the unbreak-file-size-baseline branch August 7, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant