fix: unbreak main's fmt gate, and stop the parked span vanishing from the observatory journal and fleet row (#1857 follow-up)

[macanderson]

Follow-up to #1994 (which merged while this was being written). Two independent things, the first urgent.

1. Unbreak main — cargo fmt --check is red

#1994 left crates/stella-protocol/src/event/tests.rs without a trailing newline, so cargo fmt --check fails on main and every open PR inherits the red. One character.

My break, and worth recording how it escaped: the mod tag_table; declaration was appended by a heredoc after that PR's rustfmt pass, so the local gate had already run over the file in its earlier shape and reported green.

2. Three wildcard consumers where the park silently regressed

Adding TurnParked/TurnWoken broke five crates one at a time — the compiler caught those. It could not catch the consumers matching AgentEvent behind a wildcard, and because the park used to arrive as Text, all three silently got worse when it became its own variant:

• stella-observatory execution_journal selects an event_type allowlist. 'text' was on it; 'turn_parked'/'turn_woken' were not — so the park disappeared entirely from the transcript an operator opens to ask why an execution took so long. It is the one event that explains a wall-clock gap containing no other events.
  • Added to the allowlist, plus journal_entry arms carrying the payload (a row saying a park happened but not what was awaited or for how long answers nothing), plus a frontend arm in assets/index.html — without one it fell through to the "answer" branch and drew a blank row.
• stella-tui fleet dashboard froze row.action on the last tool, so a worker deliberately waiting read as one stuck mid-tool. New LastAction::Parked rather than reusing Blocked: Blocked means a human must act, and a park needs nobody — mislabelling it would send an operator hunting an approval prompt that does not exist. TurnWoken deliberately holds the park rather than clearing to Idle, since the next tool or message repaints a beat later and clearing would only flicker.

Deliberately not done

• stella-serve's TallyFold (observe/tally.rs) drops both variants into _ => {}. Not a regression (the park was already dropped as Text), but its own doc says a turn whose stages stop advancing is wedged — and park/wake are exactly the signal distinguishing a deliberate wait from a hang. Filed rather than bundled, since it means adding a field to TurnTally.
• TENDENCY_EVENT_TYPES excludes park/wake. Judged correct, not accidental: every other member is a defect or corrective signal (retry, loop, budget denial, fallback); a park is normal intended operation.

Note on the file-size gate

main is also red on file-size — driver.rs and pipeline/tests.rs are each +1 over ceiling from a parallel-merge skew. Neither file is touched here, and #2003 is already the unbreak for it, so this PR deliberately does not duplicate that baseline regeneration.

Refs #1857

Summary by Sourcery

Unbreak the main branch formatting gate and update observability surfaces so parked and woken spans are correctly included and represented in operator-facing views.

Bug Fixes:

• Restore display of parked and woken spans in the observatory execution journal and fleet dashboard so operators can see and understand deliberate waits.
• Fix the main branch formatting gate by restoring the trailing newline in stella-protocol event tests.

Enhancements:

• Extend observatory journal payload handling and frontend rendering to show detailed context for turn_parked and turn_woken events.
• Add a distinct Parked last-action state in the TUI fleet dashboard to accurately represent engine-side waits without mislabeling them as human-blocked.

[sourcery-ai]

Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
stella-cli-docs	Ignored		Aug 7, 2026 2:59am

[sourcery-ai]

Reviewer's Guide

Fixes main’s formatting gate by restoring a trailing newline, and makes parked/woken turn events visible and semantically correct in the observatory journal and TUI fleet dashboard.

Flow diagram for handling TurnParked and TurnWoken events in observatory and TUI

flowchart TD
  AgentEvent_TurnParked["AgentEvent::TurnParked"]
  AgentEvent_TurnWoken["AgentEvent::TurnWoken"]

  subgraph Observatory_journal
    DB_query["execution_journal SQL event_type IN (... 'turn_parked', 'turn_woken')"]
    journal_entry_fn["journal_entry adds payload fields"]
    html_render["index.html renders turn_parked / turn_woken rows"]
  end

  subgraph TUI_fleet_dashboard
    LastAction_enum["LastAction adds Parked(String)"]
    TaskRow_action["TaskRow action formatting for Parked"]
  end

  AgentEvent_TurnParked --> DB_query
  AgentEvent_TurnWoken --> DB_query

  DB_query --> journal_entry_fn --> html_render

  AgentEvent_TurnParked --> LastAction_enum
  LastAction_enum --> TaskRow_action

Loading

File-Level Changes

Change	Details	Files
Restore cargo fmt gate on main by fixing a missing trailing newline in the protocol event tests.	Add trailing newline after the tag_table module declaration in the event tests to satisfy rustfmt and fmt gate. Ensure no behavioral changes to tests or event wiring; purely formatting/unbreak change.	crates/stella-protocol/src/event/tests.rs
Expose turn_parked and turn_woken events correctly in the observatory’s journal query and JSON shaping.	Extend the SQL allowlist of event_type values used for execution journals to include turn_parked and turn_woken so parked spans and wakes are persisted and retrievable. Add journal_entry shaping for turn_parked to carry description, poll_interval_secs, and deadline_secs fields into the JSON output. Add journal_entry shaping for turn_woken to carry reason and polls_used into the JSON output, instead of dropping them.	crates/stella-observatory/src/db.rs
Render parked/woken events explicitly in the observatory HTML frontend instead of falling through to a generic answer row.	Add a dedicated rendering branch for turn_parked that shows description plus poll interval and deadline in the execution journal UI. Add a dedicated rendering branch for turn_woken that explains the wake reason (changed vs deadline_expired vs other) and the number of polls used. Prevent parked spans from incorrectly rendering as blank ‘answer’ rows in the journal.	crates/stella-observatory/src/assets/index.html
Reflect engine-side park state in the TUI fleet dashboard by introducing a distinct LastAction::Parked and wiring park/wake events into row.action.	Extend LastAction enum with a Parked(String) variant, documented as engine-side wait that requires no human intervention. Update TaskRow::action_text to render parked actions as “parked: …” with the description. Handle AgentEvent::TurnParked in FleetBoard by setting row.action to LastAction::Parked(first_line(description)), avoiding the previous behavior where the row stayed on the last tool action. Handle AgentEvent::TurnWoken as a no-op on row.action, keeping the parked state until the subsequent tool/message repaint, avoiding idle flicker while preserving wake semantics.	crates/stella-tui/src/fleet_dashboard.rs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[macanderson]

CI red here is entirely inherited from main — none of it is in this diff. Verified locally on a pristine origin/main checkout, so a reviewer does not have to re-derive it:

Failure	On pristine main?	Already fixed by
file size ratchet — driver.rs +1, pipeline/tests.rs +1	yes	#2003, #2008, #2009
cargo clippy -D warnings — dead code in pipeline/tests/verification_hardening.rs, unused spend	yes (exit 101)	#2000, #2008, #2009
cargo doc -D warnings — unresolved intra-doc link to CompactionRewrite (event.rs:542)	yes	#2010
cargo fmt --check — missing trailing newline, event/tests.rs	yes	this PR — nothing else fixes it

Files this PR touches: stella-observatory/src/db.rs, stella-observatory/src/assets/index.html, stella-tui/src/fleet_dashboard.rs, stella-protocol/src/event/tests.rs. None of the three inherited failures is in any of them.

The fmt row is the one that matters for sequencing: it is my break from #1994, no other open PR carries the fix, and it is red on main and therefore on every open PR until this lands.

One methodology note worth recording, since it is why I nearly missed this: I first checked clippy with cargo clippy … | rg "^error" and read the empty result as green. Cargo's output carries ANSI escapes before the word error, so ^error never matches — the pipeline lies. Checking $? instead gives 101.

[macanderson]

Deadlock found — see #2015. Verified against origin/main at 6c34553: main is red on five gates, and #2003 and #2005 are each red on precisely the gate the other repairs — #2003 (baseline only) fails wire-schema because main's docs/wire/ is stale; #2005 (wire + park consumers) fails file-size because the baseline skew is #2003's fix. Neither can go green alone, which is why all three unbreak PRs have sat open while main stayed red.

#2015 carries the hunks from this PR plus the others so the set can land in one merge. The substantive work is yours — I collected it rather than re-deriving it, and said so in that PR. If you would rather sequence these individually, the equivalent fix is to add the other half to one of these branches; either route works, but a lone merge of any single one will stay red.

All five gates verified green on the combined tree: workspace clippy -D warnings, the rustdoc gate, fmt --check, check-file-size.sh, and make wire-schema, plus tests on the four affected crates.

[macanderson]

Superseded by #2015 — this can be closed.

#2015 now contains every commit from this branch, byte-for-byte (it picked them up from fix-1857-parked-wait-consumers):

• the event/tests.rs trailing-newline fmt fix — identical blob (30d80d2d..72cfda5e);
• the observatory journal allowlist + journal_entry arms + the assets/index.html frontend arm;
• LastAction::Parked and the fleet-dashboard fold arms, comments included.

…and it additionally carries the pipeline clippy fixes and a CompactionRewrite doc-link fix with the docs/wire regen that fix requires (see my note on #2010, which makes the same edit without the regen and so fails wire-schema).

So #2015 is the strictly-larger, correct one. Landing both risks the duplicate-unbreak collision this repo has already hit twice; landing #2015 alone loses nothing from here.

Leaving the close to a human rather than doing it myself, since I cannot tell from outside whether anything else is sequenced behind this branch.

The one thing that must not get dropped in the shuffle: the fmt fix is the only repair for a break I introduced in #1994, and cargo fmt --check stays red on main — and therefore on every open PR — until it lands, in whichever PR carries it.