Skip to content

fix(gate): unbreak main — clippy clone_on_copy, file-size baseline, gate-parity step count #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
macanderson wants to merge 2 commits into from
+8 −8
Closed

fix(gate): unbreak main — clippy clone_on_copy, file-size baseline, gate-parity step count #1873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8684434
fix(stella-pipeline): unbreak clippy — deref the Copy GenerationParam…
Aug 6, 2026
7b82aff
fix(gate): re-true the file-size baseline and the gate's spelled step…
Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ make gate # = no-scratch + no-secrets + design-refs
# + self-driving-test (the shell harness)
```

That is twenty-four steps, and the list is not maintained by hand: it is
That is twenty-five steps, and the list is not maintained by hand: it is
`GATE_STEPS` in the `Makefile`, and `gate-parity` (`scripts/check-gate-parity.sh`)
fails if this block or CONTRIBUTING.md's stops matching it. The block had
already drifted twice before that guard existed, both times by under-reporting
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ cargo build -p stella-cli --bin stella && \
STELLA_BIN="$PWD/target/debug/stella" ./scripts/test-self-driving.sh
```

Or just `make gate`, which is the twenty-four of them in order.
Or just `make gate`, which is the twenty-five of them in order.

Do not maintain that list by hand. It is `GATE_STEPS` in the `Makefile`, and
`./scripts/check-gate-parity.sh` — itself one of the steps — fails if this fence
Expand Down
2 changes: 1 addition & 1 deletion crates/stella-pipeline/src/pipeline/witness_stage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ fn apply_role_shaping(mut config: EngineConfig, overrides: &RoleCallOverrides) -
config.max_output_tokens = Some(max_output_tokens);
}
if let Some(params) = &overrides.params {
config.params = Some(params.clone());
config.params = Some(*params);
}
config
}
Expand Down
10 changes: 5 additions & 5 deletions scripts/file-size-baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,25 +17,25 @@
1659 bench/terminal_bench_analysis/tests/test_tb21_evidence_contract.py
2269 crates/stella-cli/src/agent.rs
1751 crates/stella-cli/src/agent/tests.rs
4740 crates/stella-cli/src/command_deck.rs
1507 crates/stella-cli/src/fleet_cmd.rs
4691 crates/stella-cli/src/command_deck.rs
1504 crates/stella-cli/src/fleet_cmd.rs
2129 crates/stella-core/src/bus.rs
2580 crates/stella-core/src/driver.rs
3680 crates/stella-core/src/driver/tests.rs
1780 crates/stella-model/src/anthropic/tests.rs
2093 crates/stella-model/src/openai.rs
1565 crates/stella-model/src/zai.rs
1895 crates/stella-model/src/zai/tests.rs
3642 crates/stella-pipeline/src/pipeline.rs
3580 crates/stella-pipeline/src/pipeline.rs
2568 crates/stella-pipeline/src/pipeline/tests.rs
2962 crates/stella-protocol/src/event.rs
2964 crates/stella-protocol/src/event.rs
1995 crates/stella-store/src/lib.rs
2268 crates/stella-store/src/tests.rs
1916 crates/stella-store/src/usage.rs
1569 crates/stella-tools/src/media.rs
2184 crates/stella-tools/src/registry.rs
1839 crates/stella-tools/src/scripts.rs
1528 crates/stella-tui/src/deck_render.rs
1531 crates/stella-tui/src/deck_render.rs
4006 crates/stella-tui/src/deck_ui.rs
1665 crates/stella-tui/src/views/engine.rs
1611 crates/stella-tui/src/views/session.rs
Loading