fix(gate): unbreak main — file-size baseline skew and a stale gate-parity count - #1845
fix(gate): unbreak main — file-size baseline skew and a stale gate-parity count#1845macanderson wants to merge 2 commits into
Conversation
…retighten `main` fails `check-file-size` at 5650c88: crates/stella-protocol/src/event.rs 2964 over 2962 (+2) crates/stella-tui/src/deck_render.rs 1531 over 1528 (+3) Parallel merge skew, not a real regression. #1805 retightened the baseline to the then-current counts (retiring #1797's raises), and #1813 and #1828 were already in flight with CI green against the OLD ceilings. Every open PR now inherits the red. Both growths are genuinely irreducible, which is the case AGENTS.md's escape hatch names rather than the expedient it forbids: - `event.rs` +2 is #1813 expanding the doc comment on `StageKind::Witness` to say authoring runs AFTER execution. A doc comment cannot be moved off its item, and it is a wire-contract type — the doc IS the contract. - `deck_render.rs` +3 is #1828's `SessionPhase::Stopped => TEXT_TERTIARY` arm plus the two lines saying why a deliberate stop is not painted red. A match arm cannot live in a sibling module; the match must be exhaustive. Neither is a split someone declined to do. #1828 in fact did the split where one was possible, moving the sessions projection into `sessions_view.rs`. Regenerated rather than hand-edited, so the diff also carries what the same two PRs SHRANK, and the net effect is a tighter ratchet, not a looser one: command_deck.rs 4740 -> 4691 (-49, #1828's sessions_view.rs split) pipeline.rs 3642 -> 3580 (-62, #1813 moving WITNESS_SYSTEM_PROMPT) fleet_cmd.rs 1507 -> 1504 (-3) Four ceilings down, two up by five lines total. The god-file SET is unchanged, so AGENTS.md's table and the crate READMEs need no edit — `check-god-files` confirms.
There was a problem hiding this comment.
Sorry @macanderson, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the file-size gate baseline to reconcile main with recent merged changes, tightening several ceilings and slightly raising two to account for legitimate, irreducible line growth, so that check-file-size/check-god-files pass again on current main. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
…aid 24 `module-reachability` (#1750) joined `GATE_STEPS`, and `self-driving-test` (#1753) joined it in the same window. Both documents name the new steps correctly in their lists — only the spelled-out totals were left behind, which is the exact half `check-gate-parity.sh` exists to catch and the direction that misleads: a reader runs the list, sees green, and believes the gate is green. check-gate-parity: OK — 25 (twenty-five) gate steps, named in AGENTS.md and CONTRIBUTING.md.
Second fix added:
|
| Step | Result |
|---|---|
check-file-size |
OK — 32 grandfathered, none grew |
check-god-files |
OK — 24 god files, set unchanged |
check-gate-parity |
OK — 25 (twenty-five) steps |
make guards-fast |
clean |
make self-driving-test |
60 / 60 |
|
Overlap note: #1863 carries the same two-line gate-parity count fix as this PR's second commit, byte-identical. Whichever lands first wins; the other should drop cleanly. The |
|
Expect Pre-existing at So this PR's own two fixes are verified locally rather than by that job:
Once #1873 or #1859 lands, |
…el step additions Two gate steps landed on main in parallel — module-reachability (#1833) and self-driving-test in GATE_STEPS (#1821) — and each PR bumped the spelled-out count from twenty-three to twenty-four, so their merge left both AGENTS.md and CONTRIBUTING.md claiming twenty-four steps while GATE_STEPS holds twenty-five. check-gate-parity.sh catches exactly this, which is why docs-guards went red on every PR based on current main. The step lists themselves already name every step; only the two counts were stale. Same fix as the parallel unbreak PRs #1845/#1863 — the edits are identical, so whichever lands first the others still merge clean. Refs #1815
What & why
mainfailscheck-file-sizeat5650c889, so every open PR inherits the red:Parallel merge skew, not a real regression. #1805 retightened the baseline to the then-current counts (retiring #1797's raises), and #1813 and #1828 were already in flight with CI green against the old ceilings.
Why this is
make file-size-updateand not a splitAGENTS.md allows a ceiling to move only when the growth is genuinely irreducible, and CLAUDE.md is explicit that raising one to dodge a real split is a defect. Both of these are the former:
event.rsStageKind::Witnessto say authoring runs after executiondeck_render.rsSessionPhase::Stopped => theme::TEXT_TERTIARYarm, plus two lines saying why a deliberate stop is not painted redNeither is a split someone declined to do. #1828 in fact did split where one was possible — it moved the sessions projection into
command_deck/sessions_view.rsprecisely becausecommand_deck.rssat at its exact ceiling.The baseline gets tighter, not looser
Regenerated rather than hand-edited, so the diff also carries what those same two PRs shrank:
Four ceilings down by 114 lines, two up by 5. Net the ratchet is stricter than before this PR.
The witness
The god-file set is unchanged — only counts moved — so AGENTS.md's table and the crate READMEs need no edit, and
check-god-filesconfirms that rather than my asserting it.Note on recurrence
This is the fourth distinct god-file ceiling break on
maintoday (#1761deck.rs, thendriver.rs/registry.rsin #1800, now these two). The first three were "PR merged with a red gate"; this one is different — both PRs were green when they ran, and the baseline moved underneath them.enforce_adminsis nowtrue, which closes the first mechanism but not this one: a retighten and an in-flight PR can still cross. Worth knowing before concluding the class is closed.Summary by Sourcery
Update file-size baseline to reconcile ceilings with recent god-file splits and documentation additions so the size gate reflects current main.
Bug Fixes:
Enhancements:
Chores: