Skip to content

[codex] Improve macosrsr table tests#99

Merged
grahamgilbert merged 5 commits into
mainfrom
codex/macosrsr-tests
Jun 3, 2026
Merged

[codex] Improve macosrsr table tests#99
grahamgilbert merged 5 commits into
mainfrom
codex/macosrsr-tests

Conversation

@grahamgilbert

Copy link
Copy Markdown
Member

Summary

  • add macosrsr column and generator coverage
  • make SystemVersion.plist reads and sw_vers calls injectable for deterministic tests
  • cover unsupported macOS versions, sw_vers failures, invalid versions, and invalid plist input

Validation

  • GOCACHE=/tmp/osquery-extension-go-cache go test ./tables/macosrsr
  • GOCACHE=/tmp/osquery-extension-go-cache go test ./...

@grahamgilbert grahamgilbert marked this pull request as ready for review June 3, 2026 18:37
@grahamgilbert grahamgilbert merged commit e2a553a into main Jun 3, 2026
10 checks passed
@grahamgilbert grahamgilbert deleted the codex/macosrsr-tests branch June 3, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant