Simplify: use github.token for all branch updates - #29
Merged
Conversation
The Jeeves app token was only needed to comment @dependabot rebase on Dependabot PRs, but GitHub App bots cannot be repository collaborators so Dependabot always rejected those comments. The solution was to use github.token (github-actions[bot]) for the update-branch call instead. Since all PRs now use the same token and the same mechanism, there is no need to distinguish by author or to generate a Jeeves app token at all. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use Jeeves app token (actions/create-github-app-token) instead of github.token so that the rebase push triggers downstream workflows. Branch updates are performed with gh pr update-branch --rebase via CLI, not by commenting on the PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Jeeves app token step entirely. Since
github-actions[bot]now handles all branch updates (Dependabot and non-Dependabot alike), the app token was serving no purpose.The simplified workflow:
actions/create-github-app-tokenstepgh pr update-branch --rebaseloop usinggithub.token