Skip to content

fix: point workflows at the #346 review-mode defect fixes, prune closed triage - #352

Open
m2ux wants to merge 1 commit into
mainfrom
fix/346-review-mode-definition-defects
Open

fix: point workflows at the #346 review-mode defect fixes, prune closed triage#352
m2ux wants to merge 1 commit into
mainfrom
fix/346-review-mode-definition-defects

Conversation

@m2ux

@m2ux m2ux commented Jul 29, 2026

Copy link
Copy Markdown
Owner

The main-repo half of the #346 review-mode definition fixes. The definitions themselves are in #351, which targets workflows.

Merge #351 first. This PR's submodule pointer resolves only once that branch's commit is on the remote's workflows branch.

What is here

Submodule pointer → the #351 commit.

Guard triage prune (scripts/binding-fidelity-triage.json, 4 entries). Each recorded an orphan-input finding for a value work-package read with no producer: assumption_decisions, issue_request, and comprehension_dir on two techniques. DI-20 closed all four by declaring them as workflow variables, so the entries now match nothing — and a stale entry is reported exactly like an untriaged finding, so leaving them turns binding-fidelity red.

Walk re-baseline (6 snapshots + corpus stamp), per the procedure the stamp mismatch prints. The path diff is the intended step change and nothing else:

  • every policy loses the retrospective-confirm checkpoint and gains announce-retrospective and verify-artifact-links. Worth noting what the old snapshot recorded for that checkpoint: setVariable: undefined on its only reachable option — decisionless ceremony on the face of it, which is why DI-19 converts it to a message rather than keeping the gate.
  • the review-mode policy additionally reaches create-complete-doc, render-token-usage and publish-close-out-artifacts — the three steps DI-18, DI-21 and DI-32 open on the review path.

Why one PR and not three

The prune, the pointer and the baselines are one matched set. Apart, any half turns a guard or the suite red: the prune without the declarations reports four untriaged findings, the declarations without the prune reports four stale entries, and the pointer without the re-baseline fails six snapshots plus the stamp check.

Verification

  • 17/17 guards pass against the new corpus.
  • 742 tests pass. One failure, session-crypto's EACCES case, is pre-existing and environmental — it fails identically with this change stashed, because the sandbox this ran in presents / such that mkdir returns ENOENT where the test asserts EACCES.
  • The corpus stamp and the submodule pointer both name the same commit.

Refs #346

🤖 Generated with Claude Code

@m2ux
m2ux force-pushed the fix/346-review-mode-definition-defects branch 8 times, most recently from 37bd5b1 to e1213b6 Compare July 29, 2026 16:45
…ed triage

Bumps the workflows submodule to the branch closing the 27 review-mode
definition defects issue #346 registers, and carries the two baselines that
change with it.

Four binding-fidelity triage entries go: each recorded an `orphan-input` finding
for a value the work-package workflow read with no producer —
`assumption_decisions`, `issue_request`, and `comprehension_dir` on two
techniques. DI-20 closed all four by declaring the values as workflow
variables, so the entries now match nothing, and a stale entry is reported
exactly like an untriaged finding.

The six walk snapshots and the corpus stamp are re-baselined against the new
corpus, per the procedure the stamp mismatch prints. The walk diff is the
intended path change and nothing else:

- every policy loses the `retrospective-confirm` checkpoint and gains
  `announce-retrospective` and `verify-artifact-links`. The snapshot recorded
  that checkpoint as `setVariable: undefined` on its only reachable option,
  which is `checkpoint-requires-decision` on the face of it — DI-19 converts it
  to a message.
- the review-mode policy additionally reaches `create-complete-doc`,
  `render-token-usage` and `publish-close-out-artifacts`, the three steps
  DI-18, DI-21 and DI-32 open on the review path.

The prune, the pointer and the baselines are one matched set: apart, any half
turns the guard or the suite red.

Refs #346

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@m2ux
m2ux force-pushed the fix/346-review-mode-definition-defects branch from e1213b6 to 36928c5 Compare July 29, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant