PROTO-575: Deprecate merkle root#178
Closed
SC4RECOIN wants to merge 10 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes merkle root-based earner verification and simplifies the earner management system by moving add/remove earner functionality from open instructions to portal-only instructions.
Key Changes:
- Removed merkle proof verification logic and associated utilities
- Simplified
propagate_indexto no longer update earner merkle root - Consolidated earner management under portal authority control
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| programs/portal/src/instructions/release_inbound.rs | Removed earner root parameter from propagate_index CPI call |
| programs/earn/src/utils/mod.rs | Removed merkle_proof module export |
| programs/earn/src/utils/merkle_proof.rs | Deleted entire merkle proof verification implementation |
| programs/earn/src/state.rs | Renamed earner_merkle_root field to padding |
| programs/earn/src/lib.rs | Simplified function signatures by removing merkle proof parameters |
| programs/earn/src/instructions/portal/remove_earner.rs | New portal-controlled earner removal without merkle verification |
| programs/earn/src/instructions/portal/propagate_index.rs | Removed merkle root update logic from index propagation |
| programs/earn/src/instructions/portal/mod.rs | Added new earner management module exports |
| programs/earn/src/instructions/portal/add_earner.rs | New portal-controlled earner addition without merkle verification |
| programs/earn/src/instructions/open/remove_registrar_earner.rs | Deleted open remove earner with merkle verification |
| programs/earn/src/instructions/open/mod.rs | Deleted open instructions module |
| programs/earn/src/instructions/open/add_registrar_earner.rs | Deleted open add earner with merkle verification |
| programs/earn/src/instructions/mod.rs | Removed open module export |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Oighty
requested changes
Dec 11, 2025
Oighty
left a comment
Oighty
left a comment
Collaborator
There was a problem hiding this comment.
Pretty clean update. Needs a few changes.
| pub portal_authority: Pubkey, // portal authority that propogates indexes and roots | ||
| pub admin: Pubkey, // can update config values | ||
| pub m_mint: Pubkey, // $M mint | ||
| pub portal_authority: Pubkey, // portal authority that propogates indexes and roots |
Collaborator
There was a problem hiding this comment.
We need an instruction to be able to update the portal_authority.
ith-harvey
requested changes
Dec 11, 2025
Collaborator
|
Closing PR for now. May include in a future update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.