Skip to content

Grant write permission to the publish-website action#1832

Merged
swankjesse merged 1 commit into
masterfrom
jwilson.0722.grant_write
Jul 22, 2026
Merged

Grant write permission to the publish-website action#1832
swankjesse merged 1 commit into
masterfrom
jwilson.0722.grant_write

Conversation

@swankjesse

Copy link
Copy Markdown
Collaborator

No description provided.

@swankjesse

Copy link
Copy Markdown
Collaborator Author

In an attempt to fix this failure.
https://github.com/lysine-dev/okio/actions/runs/29934672801/job/88978978141

[command]/usr/bin/git add --all .
[command]/usr/bin/git checkout -b github-pages-deploy-action/phmv36a9p
Switched to a new branch 'github-pages-deploy-action/phmv36a9p'
[command]/usr/bin/git commit -m Deploying to gh-pages from  @ 0ed6b03a1a001a1bfcdc18f6658c41500be21d1a 🚀 --quiet --no-verify
[command]/usr/bin/git push --force ***github.com/lysine-dev/okio.git github-pages-deploy-action/phmv36a9p:gh-pages
remote: Permission to lysine-dev/okio.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/lysine-dev/okio.git/': The requested URL returned error: 403
Running post deployment cleanup jobs… 🗑️
[command]/usr/bin/git worktree remove github-pages-deploy-action-temp-deployment-folder --force

Comment on lines +152 to +153
permissions:
contents: write

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be on the deploy step. Otherwise it's a potential supply chain attack across all actions instead of just that single one.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s gotta be on the entire job unfortunately. This is on master so if we get hacked there, we’re already hacked there.

Screenshot 2026-07-22 at 1 28 06 PM

@swankjesse
swankjesse merged commit 3b16d9b into master Jul 22, 2026
14 checks passed
@swankjesse
swankjesse deleted the jwilson.0722.grant_write branch July 22, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants