Skip to content

Commit shaper state only when tc succeeds #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ooonea wants to merge 2 commits into from
Closed

Commit shaper state only when tc succeeds #402

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cbabac
Commit shaper state only when tc succeeds
ooonea Aug 16, 2026
498e866
Log the failed tc change as a warning
ooonea Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cake-autorate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,12 @@ set_shaper_rate()

if ((adjust_shaper_rate[${direction}]))
then
tc qdisc change root dev "${interface[${direction}]}" cake bandwidth "${shaper_rate_kbps[${direction}]}Kbit" 2> /dev/null
# on failure keep the previous internal state so the change is retried on the next update
if ! tc qdisc change root dev "${interface[${direction}]}" cake bandwidth "${shaper_rate_kbps[${direction}]}Kbit" 2> /dev/null
then
log_msg "WARNING" "Failed to change CAKE bandwidth on ${interface[${direction}]}."
return 1
fi
else
((output_cake_changes)) && log_msg "DEBUG" "adjust_${direction}_shaper_rate set to 0 in config, so skipping the corresponding tc qdisc change call."
fi
Expand Down