Skip to content

Validate command output display mutations#82

Merged
lynnswap merged 2 commits into
mainfrom
codex/fix-command-output-display-mutations
Jul 4, 2026
Merged

Validate command output display mutations#82
lynnswap merged 2 commits into
mainfrom
codex/fix-command-output-display-mutations

Conversation

@lynnswap

@lynnswap lynnswap commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Purpose
Prevent incremental ReviewMonitor log updates from applying source-space mutations to display-space documents, which could collapse paragraph boundaries around command output panels.

Changes

  • Derive display document append/replacement changes from actual display text and validate them against the previous display document before applying incrementally.
  • Fall back to full reload when a mapped display mutation is not self-consistent, while surfacing debug assertions in the scroll view guards.
  • Invalidate the full appended display suffix when markdown presentation needs to be recomputed across multi-block appends.
  • Add regressions for command output panels followed by markdown headings, status/duration updates preserving paragraph boundaries, and multi-block markdown append styling.

Testing

  • git diff --check
  • swift test --build-system swiftbuild --no-parallel
  • xcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO
  • Codex review MCP on uncommittedChanges: no findings
  • Codex review MCP on baseBranch pinned to refs/pr-fix/base/82/a09f96c223286d1259c34e88955511c05b2e6821: no findings

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 164c52b2ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Tests/ReviewUITests/ReviewUITests.swift

@lynnswap lynnswap left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 3ca1da9f5f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lynnswap lynnswap merged commit 9de0635 into main Jul 4, 2026
1 check passed
@lynnswap lynnswap deleted the codex/fix-command-output-display-mutations branch July 4, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant