Restore native ChatGPT login flow#80
Merged
Merged
Conversation
# Conflicts: # Package.resolved # Package.swift # Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Restore the native ChatGPT login flow that uses
ASWebAuthenticationSessionby forwarding the callback scheme to app-server and preserving the callback handling behavior from v0.6.2.Depends on lynnswap/CodexKit#18.
Changes
AppServerCodexReviewBackend.startLogin.ASWebAuthenticationSessionwhenever local native auth is configured and the login challenge has an authentication URL, even if the app-server response omits native metadata.account/login/completeonly when app-server returns native web-authentication metadata; otherwise wait for the existing login-completed/account-updated notifications, matching v0.6.2 behavior.Testing
swift test --build-system swiftbuild --no-parallelxcodebuild test -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj -scheme CodexReviewMonitor -destination 'platform=macOS,arch=arm64' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO