Replaced invalidateFilter - #1100
Conversation
|
There was a cleaner way to silence the |
ab9fda5 to
d7f5987
Compare
|
Removed the warnings already fixed by #1104. |
|
It's good but needs version check (6.10). Adding version checks for 6.10 isn't a good idea; instead we should bump the min. required version of Qt to 6.10 everywhere and stop supporting very old distros in git and the next release. So, please wait for now … |
tsujan
left a comment
tsujan
left a comment
There was a problem hiding this comment.
Oops! There's a problem that I missed: change(s) should be done between beginFilterChange(); and endFilterChange();. So, this needs fixing.
| hiddenItemsRestored_ = true; | ||
| invalidateFilter(); | ||
| beginFilterChange(); | ||
| endFilterChange(); |
There was a problem hiding this comment.
Changes should be done between beginFilterChange() and endFilterChange(), like this:
if(!hiddenItemsRestored_ && !items.isEmpty()) {
beginFilterChange();
hidden_.clear();
....
endFilterChange();And also in the other cases.
There was a problem hiding this comment.
Done hopefully right.
| } | ||
| } | ||
|
|
||
| void PlacesProxyModel::setHidden(const QString& str, bool hide) { |
There was a problem hiding this comment.
beginFilterChange(); is missing here:
beginFilterChange();
if(hide) {
159829d to
2b5fbc7
Compare
|
|
||
| void PlacesProxyModel::setHidden(const QString& str, bool hide) { | ||
| if(hide) { | ||
| beginFilterChange(); |
There was a problem hiding this comment.
beginFilterChange(); should be before if(hide) {.
There was a problem hiding this comment.
shouldn't do this work when tired as now...
There was a problem hiding this comment.
Should we rise Qt version in this PR too?
2b5fbc7 to
6796f35
Compare
stefonarch
changed the title
tsujan
left a comment
tsujan
left a comment
There was a problem hiding this comment.
Now it's OK, but please don't merge it until bumping of Qt version is decided and done.
3 participants
Fixes some of the warnings here #1099
The vfs-menu.c part is done with help from LLMs, so this needs a good review.