Skip to content

Fix segfault on search URI parameter with no value #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

Fix segfault on search URI parameter with no value #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/modules/vfs-search.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,21 @@ static void parse_search_uri(FmVfsSearchEnumerator* priv, const char* uri_str)

/* g_printf("parameter name/value: %s = %s\n", name, value); */

/* a parameter with no value (e.g. "show_hidden" instead of
* "show_hidden=1") carries no information; skip it rather than
* dereferencing the NULL value below */
if(value == NULL)
{
g_free(name);
if(sep)
{
params = sep + 1;
continue;
}
else
break;
}

if(strcmp(name, "show_hidden") == 0)
priv->show_hidden = (value[0] == '1') ? TRUE : FALSE;
else if(strcmp(name, "recursive") == 0)
Expand Down