lxcfs: Conditionally disable FUSE poll support unless PSI polling is enabled#727
Merged
Conversation
…enabled Suggested-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io> Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Contributor
Author
|
@mihalicyn please may you re-run the CI to see if those failures are persistent? Thanks |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@mihalicyn btw I noticed that although LXCFS 6.0 LTS does not have the PSI functionality, and thus this PR doesn't make sense for it, however the LXCFS 6.0.6 does include some commits from your PSI PR #691 that causes the host suspend issue. So I think it may be worth fixing that issue by dropping/altering certain backported commits for the next LXCFS 6.0.7 release. Thanks These look like likely suspects: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for canonical/lxd#17983
Original PR #726
Suggested-by: Alexander Mikhalitsyn aleksandr.mikhalitsyn@futurfusion.io