Fix multi-level InitRandom out-of-bounds crash

Particles/src/setup.cxx

@@ -13,8 +13,11 @@ std::vector<std::unique_ptr<NuParticleContainer>> g_nupcs;
 extern "C" void NuParticleContainers_Setup(CCTK_ARGUMENTS) {
   DECLARE_CCTK_PARAMETERS;
 
-  if (!g_nupcs.empty())
+  if (!g_nupcs.empty()) {
+    for (auto &pc : g_nupcs)
+      pc->resizeData();
     return;
+  }
 
   for (int patch = 0; patch < CarpetX::ghext->num_patches(); ++patch) {
     const auto &patchdata = CarpetX::ghext->patchdata.at(patch);

TestNuPcsArdBH/src/testnupcsardbh.cxx

@@ -24,6 +24,9 @@ extern "C" void TestNuPcsArdBH_InitParticles(CCTK_ARGUMENTS) {
   for (int patch = 0; patch < ghext->num_patches(); ++patch) {
     auto &pc = g_nupcs.at(patch);
 
+    if (pc->TotalNumberOfParticles() > 0)
+      continue;
+
     // Phase 1: Use AMReX InitRandom for positions + zero momenta
     // For SoA particles, InitRandom randomly generates positions into SoA
     // slots 0-2 (ignoring pdata.real_array_data[0..2]), and copies

TestNuPcsArdBH/test/nupcsardbh-level3.par

@@ -0,0 +1,91 @@
+ActiveThorns = "
+  ADMBaseX
+  BoxInBox
+  CarpetX
+  IOUtil
+  Particles
+  SingleBH
+  TestNuPcsArdBH
+"
+
+Cactus::presync_mode = "mixed-error"
+Cactus::cctk_itlast = 128
+
+CarpetX::verbose = yes
+CarpetX::poison_undefined_values = yes
+
+CarpetX::xmin = +2.5
+CarpetX::xmax = +12.5
+CarpetX::ymin = -2.0
+CarpetX::ymax = +10.0
+CarpetX::zmin = -2.55
+CarpetX::zmax = +2.45
+
+CarpetX::ncells_x = 100
+CarpetX::ncells_y = 120
+CarpetX::ncells_z = 50
+
+CarpetX::periodic_x = yes
+CarpetX::periodic_y = yes
+CarpetX::periodic_z = yes
+
+CarpetX::max_grid_size_x = 10000000
+CarpetX::max_grid_size_y = 10000000
+CarpetX::max_grid_size_z = 10000000
+
+CarpetX::max_tile_size_x = 10000000
+CarpetX::max_tile_size_y = 10000000
+CarpetX::max_tile_size_z = 10000000
+
+CarpetX::blocking_factor_x = 2
+CarpetX::blocking_factor_y = 2
+CarpetX::blocking_factor_z = 2
+
+CarpetX::ghost_size = 2
+CarpetX::dtfac = 0.5
+
+CarpetX::regrid_error_threshold = 1.0
+CarpetX::max_num_levels = 3
+
+BoxInBox::num_regions = 1
+BoxInBox::shape_1 = "cube"
+BoxInBox::position_x_1 = 7.5
+BoxInBox::position_y_1 = 4.0
+BoxInBox::position_z_1 = -0.05
+BoxInBox::num_levels_1 = 3
+BoxInBox::radius_x_1 = [ -1.0, 2.5, 1.25 ]
+BoxInBox::radius_y_1 = [ -1.0, 2.5, 1.25 ]
+BoxInBox::radius_z_1 = [ -1.0, 1.25, 0.625 ]
+
+ADMBaseX::initial_data = "Schwarzschild"
+
+SingleBH::mass = 1.0
+
+TestNuPcsArdBH::num_particles = 512
+TestNuPcsArdBH::random_seed = 42
+TestNuPcsArdBH::containing_bx_xmin = +5.0
+TestNuPcsArdBH::containing_bx_xmax = +5.0 + 0.1
+TestNuPcsArdBH::containing_bx_ymin = +5.0
+TestNuPcsArdBH::containing_bx_ymax = +5.0 + 0.1
+TestNuPcsArdBH::containing_bx_zmin = -0.05
+TestNuPcsArdBH::containing_bx_zmax = +0.05
+
+IO::out_dir = $parfile
+IO::out_every = 32
+IO::parfile_write = no
+
+CarpetX::out_adios2_every = 0
+CarpetX::out_silo_every = 0
+CarpetX::out_openpmd_every = 0
+
+CarpetX::out_performance = no
+CarpetX::out_metadata = no
+CarpetX::out_tsv_vars = ""
+
+#CarpetX::out_silo_vars = "
+#  ADMBaseX::lapse
+#"
+
+Particles::out_tsv_every = 32
+Particles::out_plot_every = 0
+Particles::out_escaped_tsv = "yes"

scripts/mctx.th

@@ -151,7 +151,7 @@ Numerical/AEILocalInterp
 CarpetX/ADMBaseX
 #CarpetX/Algo
 CarpetX/Arith
-#CarpetX/BoxInBox
+CarpetX/BoxInBox
 CarpetX/CarpetX
 CarpetX/CarpetXRegrid
 CarpetX/CoordinatesX