Add quiet mode to test suite and remove verbose package banners - #28
Conversation
- Add --quiet/-q flag to run_tests.sh that shows only checkmark on success or failure messages on error - Add -quiet flag to AllTests.wl with same behavior - Remove verbose package loading banners from all src/*.wl modules - Remove "Loading/completed" print statements from unit test files - Update documentation in AGENTS.md, CLAUDE.md, and README.md to reflect the new quiet mode options The quiet mode is useful for CI environments and when running tests repeatedly during development, reducing noise while still reporting failures clearly.
Pull Request ReviewSummaryThis PR adds quiet mode functionality to the test suite and removes verbose package loading banners. The implementation is well-executed with good attention to detail. Overall, this is a solid contribution that improves the developer experience. Strengths1. Excellent Code Quality
2. Good Design Decisions
3. Comprehensive Coverage
4. Documentation
Issues Found1. Bug: Incomplete Failure Capture in run_tests.sh (MODERATE)Location: test/run_tests.sh:224 The grep pattern only captures FAIL or FAILED, but misses ERROR, REGRESSION DETECTED, and SKIP warnings. Recommendation: Use grep -E "(FAIL|FAILED|ERROR|REGRESSION)" 2. Code Smell: Print Suppression via Block (MINOR)Location: test/AllTests.wl:42 Globally suppressing Print could hide unexpected errors from Get[file]. Since you removed the Loading/completed messages, this Block might be unnecessary. 3. Missing Edge Case: Unit Test Failures in Quiet Mode (MINOR)Location: test/AllTests.wl:53-57 Unit test failures from TestReport are not captured or displayed in quiet mode. Consider adding AppendFailure for failed unit tests. 4. Shell Injection Validation Issue (LOW PRIORITY)Location: test/AllTests.wl:75 The validation regex allows periods and slashes which could enable directory traversal. Risk is very low since input comes from test_cases.txt in the repo. Minor Suggestions5. Inconsistent Quiet Mode Flag
Worth documenting explicitly in help text. 6. Documentation: Consider Adding Example OutputShowing before/after output would be helpful for users. Security AssessmentNo security concerns. Changes are cosmetic with proper validation. Test CoverageExcellent coverage of quiet mode. Missing: Unit test for quiet mode with failing tests. Overall AssessmentRating: Approve with minor suggestions This is a well-implemented feature. Issues found are minor and the PR can be merged as-is. Priority Recommendations:
Breaking Changes: None - fully backward compatible Great work! This will make CI/CD logs much cleaner. |
Summary
--quiet/-qflag torun_tests.shthat shows only checkmark on success or failure messages on error-quietflag toAllTests.wlwith the same behaviorsrc/*.wlmodulesTest plan
./test/run_tests.shto verify normal verbose mode still works./test/run_tests.sh --quietto verify quiet mode shows only checkmark on successwolframscript -script test/AllTests.wlfor verbose outputwolframscript -script test/AllTests.wl -quietfor quiet output