build: fix and improve FreeRTOS build system configuration - #110
Open
heyonghau wants to merge 2 commits into
Open
build: fix and improve FreeRTOS build system configuration#110heyonghau wants to merge 2 commits into
heyonghau wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two issues with the FreeRTOS build system:
Remove redundant file collection in CMake: Previously, the build system added the FreeRTOS subdirectory and then searched for source files again to add them to compilation. This was redundant since
add_subdirectory()already handles the source file compilation.Fix USE_FREERTOS CMake option: Previously, running
cmake -B build -DUSE_FREERTOS=ONwould not properly enable FreeRTOS in the project. TheLV_USE_OSmacro was not being set correctly.Testing
cmake -B build -DUSE_FREERTOS=ON && cmake --build buildcmake -B build && cmake --build buildBoth scenarios now work as expected.
Summary by cubic
Fixes FreeRTOS build configuration and simplifies integration. USE_FREERTOS now correctly enables LVGL with FreeRTOS, and a new FREERTOS_HEAP option lets you pick the heap implementation.
New Features
Bug Fixes
Written for commit 5ab4d27. Summary will update on new commits.