Refactored the build logic to improve build with freeRTOS and in VSCode - #109
Open
Spider84 wants to merge 1 commit into
Open
Refactored the build logic to improve build with freeRTOS and in VSCode#109Spider84 wants to merge 1 commit into
Spider84 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="src/freertos_main.c">
<violation number="1" location="src/freertos_main.c:9">
P2: The FreeRTOS guard is evaluated before LVGL config macros are defined, so it always passes and defeats the intended OS gating.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| */ | ||
|
|
||
| #include "lvgl/lvgl.h" | ||
| #if LV_USE_OS == LV_OS_FREERTOS |
There was a problem hiding this comment.
P2: The FreeRTOS guard is evaluated before LVGL config macros are defined, so it always passes and defeats the intended OS gating.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/freertos_main.c, line 9:
<comment>The FreeRTOS guard is evaluated before LVGL config macros are defined, so it always passes and defeats the intended OS gating.</comment>
<file context>
@@ -6,15 +6,18 @@
*/
-#include "lvgl/lvgl.h"
+#if LV_USE_OS == LV_OS_FREERTOS
#include "FreeRTOS.h"
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Refactored the CMake build to improve FreeRTOS builds on Windows and Posix and make VSCode builds clearer. Also fixed SDL2 linking issues on Windows.
Refactors
Bug Fixes
Written for commit 6c85807. Summary will update on new commits.