You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work getting a CI workflow started. A couple of issues that will break the build:
swift test will fail — The Package.swift only declares an executable target with no test target. SwiftPM errors with no tests found; create a target named 'BrowserProxyTests' to add tests and exits non-zero. Either remove this step or add a Tests/ target.
Hardcoded Xcode path — sudo xcode-select -s /Applications/Xcode_15.2.app pins to a specific Xcode version. The macos-14 runner ships with Xcode 15.x by default, so this step is unnecessary and will break if the runner image drops Xcode_15.2.app. Consider removing it, or use sudo xcode-select -s /Applications/Xcode.app.
Minor: Missing trailing newline at end of file.
Everything else looks good — the trigger events, macos-14 (matches the .macOS(.v14) platform requirement), and swift build -c release (consistent with build.sh) are all correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a GitHub Actions CI workflow that builds on every push/PR to main using macos-14 + Xcode 15+.