Skip to content

Set up Github Actions CI - #6

Open
mazi-eth wants to merge 1 commit into
lvchenjia:mainfrom
mazi-eth:add-github-actions-ci
Open

Set up Github Actions CI#6
mazi-eth wants to merge 1 commit into
lvchenjia:mainfrom
mazi-eth:add-github-actions-ci

Conversation

@mazi-eth

Copy link
Copy Markdown

Adds a GitHub Actions CI workflow that builds on every push/PR to main using macos-14 + Xcode 15+.

@lvchenjia
lvchenjia requested a balanced review from Copilot August 13, 2026 11:46

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@lvchenjia lvchenjia self-assigned this Aug 13, 2026
@lvchenjia

Copy link
Copy Markdown
Owner

Nice work getting a CI workflow started. A couple of issues that will break the build:

  1. swift test will fail — The Package.swift only declares an executable target with no test target. SwiftPM errors with no tests found; create a target named 'BrowserProxyTests' to add tests and exits non-zero. Either remove this step or add a Tests/ target.

  2. Hardcoded Xcode pathsudo xcode-select -s /Applications/Xcode_15.2.app pins to a specific Xcode version. The macos-14 runner ships with Xcode 15.x by default, so this step is unnecessary and will break if the runner image drops Xcode_15.2.app. Consider removing it, or use sudo xcode-select -s /Applications/Xcode.app.

  3. Minor: Missing trailing newline at end of file.

Everything else looks good — the trigger events, macos-14 (matches the .macOS(.v14) platform requirement), and swift build -c release (consistent with build.sh) are all correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants