Allow manual OAuth URL entry without waiting full callback timeout - #3
Open
cook1e0 wants to merge 1 commit into
Open
Allow manual OAuth URL entry without waiting full callback timeout#3cook1e0 wants to merge 1 commit into
cook1e0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the user experience of the manual OAuth fallback.
In the existing auth.py, the code waits the full 120 seconds for an automatic callback before prompting the user to paste the callback URL. On remote servers or SSH‑tunneled setups where the automatic callback cannot reach the container, this forces users to wait unnecessarily.
The patch adds queue to the imports and replaces the blocking wait loop with a concurrent input listener. A background thread listens for manual input while still waiting for the automatic callback, checking both sources and proceeding as soon as either one arrives. If neither a callback nor manual input is received within 120 seconds, it raises an error.
This allows users to paste the callback URL immediately without waiting, while still supporting automatic callbacks when they work.