Skip to content

Close AOF file handle after each append #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stephen0512 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Close AOF file handle after each append #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pyredis/persistence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ def log_command(self, command: Array) -> None:
class AppendOnlyFilePersistence(RedisPersistence):
def __init__(self, filename: str):
self._filename = filename
self.file = open(filename, mode="ab", buffering=0)

def log_command(self, command: Array) -> None:
self.file.write(f"*{len(command)}\r\n".encode())
with open(self._filename, mode="ab", buffering=0) as file:
file.write(f"*{len(command)}\r\n".encode())

for item in command:
self.file.write(item.resp_encode())
for item in command:
file.write(item.resp_encode())


class NoPersistence(RedisPersistence):
Expand Down