Fix/restrict open redirects#225
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
- Remove unused AllowedRedirectHosts config field (server performs no redirect; field was never read) and restore gofmt alignment - Drop unused redirect param/body from clerkAuth to match OpenAPI removal - Encode redirect when building the Clerk callback URL - Simplify validateRedirect and add unit tests covering cross-origin, protocol-relative, backslash, and javascript:/data: vectors - Restore accidentally stripped trailing newlines
Contributor
Author
|
recheck |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Regenerate management.generated.ts and resources_gen.go to match the OpenAPI spec change that dropped the AuthCallbackRequest redirect field. Fixes the failing generate CI check.
jeroenrinzema
force-pushed
the
fix/restrict-open-redirects
branch
from
0a581c8 to
aa40ed3
Compare
jeroenrinzema
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.