Drop lua-term since lua-system has the same functionality#777
Draft
IlyasYOY wants to merge 3 commits into
Draft
Conversation
Use LuaSystem's isatty implementation so busted no longer needs lua-term for tty detection.
Replace term.colors with a bundled output-handler color helper so busted can remove lua-term as a runtime dependency.
Keep packaged installs aligned with the runtime color handling changes by requiring the newer LuaSystem support, removing the old lua-term dependency, and shipping the internal colors output handler.
Author
|
Updated Checked the tests after reinstalling deps. PS. There is luacov is missing, so the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
lua-termas described here: #771 (comment)just check, no new test failures. Seems like the change in the infrastructure layer where are no tests.rgto search'testin the code, no more entries found.colors.luafromlua-termtobusted/outputHandlers/colors.lua. Mentioned it in docs. Kept it AS-IS, didn't change a thing. I might remove unused code if you think it'd be better.The only thing left to do is:
Closes: #771
I'm not sure about AI policy, so I write it here:
I'm eager to make more contributions after this one, so it'd be good to understand the AI-usage policy. I don't want to violate it.