Repository navigation
feat: route @lumyx/ui links through LumyxLinkProvider - #3
Open
FrekiManagarm wants to merge 1 commit into
Open
FrekiManagarm wants to merge 1 commit into
FrekiManagarm wants to merge 1 commit into
Conversation
@lumyx/ui 0.2.0 no longer imports next/link or next/navigation. Pass them in from the chrome so the sidebar keeps client-side navigation and its active item. Also fix the sidebar footer, which still said MIT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@lumyx/uino longer importsnext/linkornext/navigation(lumyx-dev/ui#1). The dashboard now passes them in throughLumyxLinkProvider, so the sidebar keeps client-side navigation and highlights the active item.DashboardChromeinLumyxLinkProviderwith Next'sLinkandusePathname().Test plan
bun installpicks up the current@lumyx/uimainbun run lint,bun run check-types,bun run verify:ds,bun run build