Skip to content

chore(workflows): remove unused secrets from deploy workflows for bet… - #23

Merged
lumpinif merged 1 commit into
mainfrom
fix/0312
Mar 12, 2026
Merged

chore(workflows): remove unused secrets from deploy workflows for bet…#23
lumpinif merged 1 commit into
mainfrom
fix/0312

Conversation

@lumpinif

@lumpinif lumpinif commented Mar 11, 2026

Copy link
Copy Markdown
Owner

…ter security

Summary by CodeRabbit

  • Chores
    • Updated deployment workflow configurations by removing unused authentication-related secrets from the deployment pipeline.

Copilot AI review requested due to automatic review settings March 11, 2026 19:01
@vercel

vercel Bot commented Mar 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
deepcrawl Ready Ready Preview, Comment Mar 11, 2026 7:04pm

@coderabbitai

coderabbitai Bot commented Mar 11, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: cd57fe04-1d18-4458-913b-b1716c85a2ee

📥 Commits

Reviewing files that changed from the base of the PR and between a378bfc and cce8bc9.

📒 Files selected for processing (2)
  • .github/workflows/deploy-auth-worker.yml
  • .github/workflows/deploy-v0-worker.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/deploy-v0-worker.yml
  • .github/workflows/deploy-auth-worker.yml

📝 Walkthrough

Walkthrough

Two deployment workflow files had three authentication-related secrets (BETTER_AUTH_URL, GITHUB_CLIENT_ID, GOOGLE_CLIENT_ID) removed from their configuration, along with their corresponding environment variable mappings. No other functional changes were made to the workflows.

Changes

Cohort / File(s) Summary
Deployment Workflow Configuration
.github/workflows/deploy-auth-worker.yml, .github/workflows/deploy-v0-worker.yml
Removed authentication secrets and environment variable mappings for BETTER_AUTH_URL, GITHUB_CLIENT_ID, and GOOGLE_CLIENT_ID from both workflow files.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Three secrets bid farewell, no more to hide,
From workflows that once held them deep inside,
The auth dance slows, with fewer keys to keep,
A simpler path for deployments to reap! 🔑✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: removing unused secrets from deploy workflows. It is specific, directly related to the changeset, and conveys the primary purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/0312

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes unnecessary GitHub/Better Auth/Google-related secret injections from Cloudflare deploy workflows, tightening workflow secret usage while relying on Wrangler vars for non-sensitive configuration.

Changes:

  • Removed BETTER_AUTH_URL, GITHUB_CLIENT_ID, and GOOGLE_CLIENT_ID from the Wrangler Action secrets lists.
  • Removed the corresponding env mappings that sourced those values from GitHub secrets.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/deploy-v0-worker.yml Stops injecting non-secret auth/OAuth config as Wrangler secrets during v0 worker deploys.
.github/workflows/deploy-auth-worker.yml Stops injecting non-secret auth/OAuth config as Wrangler secrets during auth worker deploys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lumpinif
lumpinif merged commit d9e9b44 into main Mar 12, 2026
8 checks passed
@lumpinif
lumpinif deleted the fix/0312 branch March 12, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants