fix bug, if string is given to force_encodig with double quotes it will return a error, escaped doubled quotes - #8
Open
Knofxx wants to merge 1 commit into
Open
fix bug, if string is given to force_encodig with double quotes it will return a error, escaped doubled quotes#8Knofxx wants to merge 1 commit into
Knofxx wants to merge 1 commit into
Conversation
Owner
|
Hey thanks for the PR, do you have a minimum example to repro ? I'll add it to the unit tests then. |
Author
Hey thanks for the reply, as example with the following string : "Net::ReadTimeout with "Net::ReadTimeout with \"timed out while waiting for more data\" and then call code |
Owner
|
Sorry I cant reproduce this. I tried the following with various kind of quoting and special characters: and it works fine for me without your patch: Can you please send me the complete code snipped that generates the problem? |
Owner
|
also please share |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.