Skip to content

fix bug, if string is given to force_encodig with double quotes it will return a error, escaped doubled quotes - #8

Open
Knofxx wants to merge 1 commit into
lumean:masterfrom
Knofxx:master
Open

fix bug, if string is given to force_encodig with double quotes it will return a error, escaped doubled quotes#8
Knofxx wants to merge 1 commit into
lumean:masterfrom
Knofxx:master

Conversation

@Knofxx

@Knofxx Knofxx commented Oct 6, 2020

Copy link
Copy Markdown

No description provided.

@Knofxx Knofxx changed the title fixed double quotes bug fix bug, if string is given to force_encodig with double quotes it will return a error, escaped doubled quotes Oct 6, 2020
@lumean

lumean commented Oct 6, 2020

Copy link
Copy Markdown
Owner

Hey thanks for the PR, do you have a minimum example to repro ? I'll add it to the unit tests then.

@Knofxx

Knofxx commented Oct 6, 2020

Copy link
Copy Markdown
Author

Hey thanks for the PR, do you have a minimum example to repro ? I'll add it to the unit tests then.

Hey thanks for the reply, as example with the following string : "Net::ReadTimeout with "Net::ReadTimeout with \"timed out while waiting for more data\" and then call code

@lumean

lumean commented Oct 12, 2020

Copy link
Copy Markdown
Owner

Sorry I cant reproduce this.

I tried the following with various kind of quoting and special characters:

gen1.code() {"
      asdfjkl \` \" \' <a href=\"example.org\"> my testlink </a>
"}

and it works fine for me without your patch:

image

Can you please send me the complete code snipped that generates the problem?

@lumean

lumean commented Oct 12, 2020

Copy link
Copy Markdown
Owner

also please share ruby -v and gem list and the operating system you are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants