feat(audio): merge native ALSA playback devices into the exclusive selector#166
Open
mikelexp wants to merge 3 commits into
Open
feat(audio): merge native ALSA playback devices into the exclusive selector#166mikelexp wants to merge 3 commits into
mikelexp wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This adds native ALSA playback-device enumeration on Linux and merges it with the existing GStreamer device list, so SONE can show real hardware PCM outputs even when PipeWire/WirePlumber does not expose them.
I added this because I wanted to use a FiiO Q1 MK2 as a direct ALSA device outside the PipeWire graph. With that setup, I can select it in Exclusive mode and get bit-perfect playback without PipeWire’s resampling or mixing path affecting the signal chain.
The implementation uses AI assistance, since I don’t code in Rust myself, but I tested it locally and it behaves correctly for my setup (ArchLinux/CachyOS). I know you’ll review the code carefully anyway, so I’m happy to defer to your judgment on anything I may have missed.
A few details on the behavior:
Also, congratulations on SONE. I really love your software. It’s easily the best Tidal experience I’ve found on Linux.