Add a log_level build option and teardown tracing#96
Merged
Conversation
std.log.debug is compiled out of Release builds, so the load stand never saw teardown or fail-fast detail. Add a -Dlog_level build option (err, warn, info, debug; default info, so prod stays clean), wired through build_options into std_options. The load stand Dockerfile builds with -Dlog_level=debug. Trace the shutdown path: produce-failed propagation, the flush worker cancel, and processor/producer deinit. Drop the two per-message debug logs from the hot loop so raising the level does not flood the output.
Contributor
📊 Benchmark ResultsCurrent run is the minimum over 3 passes, compared against the base branch (
Summary: ➡️ 11 neutral · ⚪ 2 ignored (sub-μs) Thresholds: <1μs ignore · 1–20μs 15% · 20–50μs 10% · ≥50μs 5%. Measured on a shared CI runner — treat small deltas as noise. Informational only; this check never fails the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
-Dlog_levelbuild option (err, warn, info, debug; default info). Raises the compiled-in log level sostd.log.debugis emitted; default info keeps Release/prod output clean. The value is validated atzig buildtime. Wired throughbuild_optionsintostd_options.-Dlog_level=debug(keeps ReleaseFast perf, gains the traces).processor/producerdeinit.Why
std.log.debugwas compiled out of the ReleaseFast load-stand build, so a hung teardown showed no detail. This makes the fail-fast path observable on the stand.Independent of the replication work; targets
main.