Add a debug_logs build flag and teardown tracing#94
Merged
lukashes merged 1 commit intoJul 12, 2026
Conversation
std.log.debug is compiled out of Release builds, so the load stand never saw teardown or fail-fast detail. Add a -Dlog_level build option (err, warn, info, debug; default info, so prod stays clean), wired through build_options into std_options. The load stand Dockerfile builds with -Dlog_level=debug. Trace the shutdown path: produce-failed propagation, the flush worker cancel, and processor/producer deinit. Drop the two per-message debug logs from the hot loop so raising the level does not flood the output.
lukashes
force-pushed
the
chore/debug-log-tracing
branch
from
b23c063 to
de65923
Compare
Contributor
📊 Benchmark ResultsCurrent run is the minimum over 3 passes, compared against the base branch (
Summary: ➡️ 10 neutral · 🔴 1 slower · ⚪ 2 ignored (sub-μs) Thresholds: <1μs ignore · 1–20μs 15% · 20–50μs 10% · ≥50μs 5%. Measured on a shared CI runner — treat small deltas as noise. Informational only; this check never fails the build. |
Owner
Author
|
/bench |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #92 (base is
bugfix/replication-conn-data-race); retarget tomainonce #92 merges. The teardown traces sit on top of #92's shutdown code, so this cannot branch cleanly off main.What
-Ddebug_logsbuild option: raises the log level sostd.log.debugis compiled in. Default off, so Release/prod output stays clean. Wired throughbuild_optionsintostd_options.-Ddebug_logs=true(keeps ReleaseFast perf, gains the traces).processor/producerdeinit. These pinpointed the metrics-server teardown hang (fixed separately in Stop the metrics server on cancel, not just on graceful stop #93).Why
std.log.debugwas compiled out of the ReleaseFast load-stand build, so a hung teardown showed no detail. This makes the fail-fast path observable on the stand.