Validate REPLICA IDENTITY FULL for delete-tracking streams at startup#104
Merged
Conversation
Contributor
📊 Benchmark ResultsCurrent run is the minimum over 3 passes, compared against the base branch (
Summary: 🟢 1 faster · ➡️ 9 neutral · 🔴 1 slower · ⚪ 2 ignored (sub-μs) Thresholds: <1μs ignore · 1–20μs 15% · 20–50μs 10% · ≥50μs 5%. Measured on a shared CI runner — treat small deltas as noise. Informational only; this check never fails the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79.
Problem
The docs require
REPLICA IDENTITY FULL, but nothing checked it. With the default identity the pipeline runs fine, and only DELETE events silently drop the non-key columns from the old row, contradicting the documented format. TheInvalidReplicaIdentityerror was declared in the validator but never used.Solution
PostgresValidator.checkReplicaIdentityFull: readspg_class.relreplidentand fails with an actionableALTER TABLE ... REPLICA IDENTITY FULLmessage unless the identity isf.Stream.tracksDelete). Replica identity is irrelevant for INSERT, and UPDATE emits only the new row, so an insert/update-only stream is not rejected and does not pay FULL's extra UPDATE WAL.Test
InvalidReplicaIdentity, and the check reportsConnectionFailedwhen not connected.Stream.tracksDeleteis false for insert/update-only and true when delete is present, proving delete-free streams skip the check.Docs (README, AGENTS.md) updated: FULL is needed on tables whose stream tracks DELETE, not on every tracked table.