fix: consistent naming of config files on read and write - #8
Open
LittleFoxCode wants to merge 1 commit into
Open
fix: consistent naming of config files on read and write#8LittleFoxCode wants to merge 1 commit into
LittleFoxCode wants to merge 1 commit into
Conversation
Fixes a bug where the plugin would write an empty servers.yml file only when a config.yml file was present. This caused the wrong file to be loaded on server start.
Owner
|
Why is config.yml better in this case? Its more confusing when the config folder is shared between every mod with fabric. Sure a name like trusted-travels-servers.yml would be better, config.yml is not. For me it works, even when i have an config.yml Can you explain the issue more? |
Owner
|
The config.yml is empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the plugin would write an empty servers.yml file only when a config.yml file was present. This caused the wrong file to be loaded on server start.