Remove dead code and stale configuration (#540)#554
Open
maltehuebner wants to merge 1 commit into
Open
Conversation
Dead PHP (grep-verified zero usages):
- src/Air/ImportCache/{ImportCache,ImportCacheInterface}.php
- src/Air/Util/ClassUtil.php and StringUtil.php
- src/Twig/Extension/CronTwigExtension.php (uses Cron\CronExpression,
but dragonmantank/cron-expression is not installed; the cron() Twig
function is called in no template)
- dropped the unused `use App\Entity\Zip;` import in RequestConverter
(the Zip entity does not exist)
Stale configuration:
- config/services.yaml: removed the unused `locale` parameter, the
consumer-less `$graphCacheDirectory` bind (+ GRAPH_CACHE_DIRECTORY in
.env/.env.test), and the dead alias for the non-existent
App\Air\Pollution\DataPersister namespace (the live persister lives in
App\Air\DataPersister and that FQCN is referenced nowhere).
- deleted config/packages/dev/easy_log_handler.yaml (registers
EasyCorp\EasyLog\EasyLogHandler; package not installed, abandoned)
- removed the controller-less `logout` route from
config/routing/4_frontend.yaml (no security firewall, route name
referenced nowhere)
- removed the `/phpunit.xml` line from .gitignore (the file is tracked
and consumed by CI directly)
- fixed the "Kohlemnonooxid" -> "Kohlenmonoxid" keyword typo in
sonata_seo.yaml
Docs:
- CLAUDE.md / README: corrected the search description (client-side
@algolia/autocomplete-js + Nominatim, not Elasticsearch/Bloodhound);
the Provider subsystem was already removed on main in #507.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the belegten dead code and orphaned configuration from #540. The Provider subsystem was already removed on
mainin #507, so that task is done.Changes
Dead PHP (grep-verified: zero usages)
src/Air/ImportCache/{ImportCache,ImportCacheInterface}.phpsrc/Air/Util/ClassUtil.php,src/Air/Util/StringUtil.phpsrc/Twig/Extension/CronTwigExtension.php— referencesCron\CronExpression, butdragonmantank/cron-expressionis not installed and thecron()Twig function is called in no template (first use would fatal)use App\Entity\Zip;import inRequestConverter(theZipentity does not exist)Stale configuration
config/services.yaml: removed the unusedlocaleparameter, the consumer-less$graphCacheDirectorybind (plusGRAPH_CACHE_DIRECTORYin.env/.env.test), and the dead alias targeting the non-existentApp\Air\Pollution\DataPersisternamespace. The live persister interface (App\Air\DataPersister\PersisterInterface) is the one actually injected; the old FQCN is referenced in zerousestatements, so the alias was inert (Symfony drops unused private aliases).config/packages/dev/easy_log_handler.yaml(registersEasyCorp\EasyLog\EasyLogHandler; the package is not installed and abandoned since 2020)logoutroute fromconfig/routing/4_frontend.yaml(there is no security firewall, and the route name is referenced nowhere)/phpunit.xmlfrom.gitignore(the file is git-tracked and consumed directly by CI — the ignore line was a foot-gun)Kohlemnonooxid→Kohlenmonoxidkeyword typo insonata_seo.yamlDocs
CLAUDE.md/README.md: corrected the search description — the app has no Elasticsearch integration (zero references incomposer.json/src/); search/autocomplete is client-side@algolia/autocomplete-js+ Nominatim geocoding, not "Elasticsearch"/"Typeahead/Bloodhound".Notes / deferred
elasticsearchservice still present indocker-compose.yml(anddocker/elasticsearch/) is a legacy remnant; removing the infra service/volume is out of scope for this docs+dead-code cleanup and is noted inline inCLAUDE.md.locale-parameter vstranslation.yamldefault_locale: eninconsistency is resolved by removing the unusedlocaleparameter.Verification
vendor/bin/phpstan analyse --no-progress— No errorsvendor/bin/phpunit --testsuite="Project Test Suite"— OK (121 tests)Symfony\Component\Yaml\Yaml::parseFile).vendor/lackssymfony/runtime), so the services/routing changes were verified by grep (no references to the removed ids/params/route anywhere) + YAML lint rather than a full container compile.Refs #540 (Provider-subsystem item already done in #507)
🤖 Generated with Claude Code