Skip to content

Validate geocoding search query input (#527) #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maltehuebner wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate geocoding search query input (#527) #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Controller/TypeaheadController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@

class TypeaheadController extends AbstractController
{
private const int MIN_QUERY_LENGTH = 2;
private const int MAX_QUERY_LENGTH = 128;

public function prefetchCitiesAction(RouterInterface $router): Response
{
$cityList = $this->managerRegistry->getRepository(City::class)->findAll();
Expand Down Expand Up @@ -60,8 +63,17 @@ public function prefetchStationsAction(RouterInterface $router): Response

public function searchAction(Request $request, GeocoderInterface $geocoder): Response
{
$queryString = trim((string) $request->query->get('query', ''));

if (mb_strlen($queryString) < self::MIN_QUERY_LENGTH || mb_strlen($queryString) > self::MAX_QUERY_LENGTH) {
return new JsonResponse(
['error' => sprintf('Die Suchanfrage muss zwischen %d und %d Zeichen lang sein.', self::MIN_QUERY_LENGTH, self::MAX_QUERY_LENGTH)],
Response::HTTP_BAD_REQUEST
);
}

try {
$result = $geocoder->query($request->query->get('query'));
$result = $geocoder->query($queryString);
} catch (QuotaExceeded) {
return new JsonResponse(['error' => 'Die Suche ist momentan überlastet. Bitte versuche es in einigen Sekunden erneut.'], Response::HTTP_TOO_MANY_REQUESTS);
}
Expand Down
Loading