Skip to content

fix short-path test on ci #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucuma13 merged 1 commit into from
Oct 4, 2026
Merged

fix short-path test on ci #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions internal/integrate/multi_selection_windows_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,22 @@ func TestLongPathNameExpandsShortPath(t *testing.T) {
t.Skip("no short names on this volume")
}

if got := longPathName(short); !strings.EqualFold(got, long) {
t.Errorf("longPathName(%q) = %q, want %q", short, got, long)
// Compared by identity, not by string: the temp dir may itself sit under a
// short-named component (CI's C:\Users\RUNNER~1), which is expanded too.
got := longPathName(short)
if strings.Contains(got, "~") {
t.Errorf("longPathName(%q) = %q, still has short components", short, got)
}
gotInfo, err := os.Stat(got)
if err != nil {
t.Fatal(err)
}
longInfo, err := os.Stat(long)
if err != nil {
t.Fatal(err)
}
if !os.SameFile(gotInfo, longInfo) {
t.Errorf("longPathName(%q) = %q, not the same file as %q", short, got, long)
}
}

Expand Down
Loading