Harden graph runtime, durable runs, and plugin portability - #1
Draft
JJPuertas wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The initial v0.1 review found several small but user-visible correctness and portability failures: Mermaid diagrams could not render, the plugin launcher depended on
python3on Windows, two MCP hosts could misclassify or double-resume shared runs, coding backends could execute concurrently whencwdwas omitted, and malformed reviewer/condition output could approve or strand a graph incorrectly. This change closes those issues without adding runtime dependencies.Impact
Diagrams render correctly, detached runs behave consistently across simultaneous Claude/Codex hosts, coding-agent defaults protect shared workspaces, reviewer routing is fail-safe, long prompts avoid the Windows command-line limit, and the bundled plugin cold-starts through one shared configuration on both hosts.
Validation
uv run --directory plugins/athena-graphs --extra dev --extra mcp pytest ../../tests -q: 95 passedpython -m compileall -q agentgraph: passedgit diff --check: passedclaude plugin validate plugins/athena-graphs --strict: passed--output-last-messagetransport probe: passedTested on Windows. macOS/Linux CI remains a follow-up portability check.