Allow to pass mask parameter for temporal transformer in ViVit - #356
Merged
Conversation
eyalmazuz
changed the title
This allows to pad videos to certain length which allow the transformer to ignore padded frames using batch sizes > 1
Owner
|
@eyalmazuz yea let's do it! thank you Eyal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small QoL update for ViViT, to more efficiently train ViViT videos can be in different length but right now there's no way to "pad video" to allow for batched processing of different length videos.
This feature allows to pad videos to certain length which allow the temporal transformer to ignore padded frames when using batch sizes > 1