Skip to content

ci: add coverage measurement and gate to backend-test #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucastononro wants to merge 2 commits into from
+18 −1
Closed

ci: add coverage measurement and gate to backend-test #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
417283e
ci: add pytest-cov coverage measurement and gate to backend-test
Jul 19, 2026
cd58511
fix(review): address Greptile findings on #149
lucastononro Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,20 @@ jobs:
python-version: "3.11"
cache: pip
- run: pip install -r requirements.txt
- run: pytest tests/ -v --tb=short
# Coverage is scoped to production code: backend/.coveragerc omits
# tests/ so the gate reflects untested application code (with tests
# included the total was ~66%; production-only it is ~51%).
- run: |
pytest tests/ -v --tb=short \
--cov=. \
--cov-report=xml \
--cov-report=term-missing \
--cov-fail-under=50
- uses: actions/upload-artifact@v4
if: always()
with:
name: backend-coverage
path: backend/coverage.xml
Comment on lines +52 to +56

@greptile-apps greptile-apps Bot Jul 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Artifact name not unique across concurrent runs

name: backend-coverage is a fixed string. If two PRs or branches trigger backend-test simultaneously (e.g. a push to main and an open PR), both jobs will try to upload an artifact with the same name into the same Actions scope. actions/upload-artifact@v4 will reject the second upload with a conflict error. Consider parameterising with the run id, e.g. name: backend-coverage-${{ github.run_id }}.

Fix in Claude Code


backend-security:
name: Backend Security Scan
Expand Down
3 changes: 3 additions & 0 deletions backend/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[run]
omit =
tests/*
1 change: 1 addition & 0 deletions backend/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ nbformat>=5.10.0
jupyter_client>=8.6.0
pytest>=9.0.0
pytest-asyncio>=1.3.0
pytest-cov>=6.0.0
httpx>=0.28.0

# Paper + web search backends
Expand Down
Loading