crane-serve: Wire stop-sequence and handle max_completion_tokens - #118
Merged
Conversation
`stop` was deserialized from chat/completion/generate requests but never reached the engine, which could only stop on EOS tokens or max_tokens. Agentic clients rely on stop strings to bound tool-call blocks and turn boundaries, so requests setting `stop` had no effect. Sequence now accumulates decoded text per token and checks it against the request's stop strings alongside the existing EOS/length checks, and finish_sequence truncates the returned text at the first match instead of flushing the tokenizer's trailing buffer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
max_tokens is OpenAI's legacy field name; newer clients send max_completion_tokens instead, which Crane silently ignored, falling back to the 4096 default regardless of what the client requested.
Owner
|
Hi, what does this fix |
Contributor
Author
|
It is for OpenCode, it isn't wired yet, but I'm working on MoE support. |
Contributor
Author
|
In OpenCode you can also stop a model by just pressing ESC. That sends the stop command. However we do not have support for it which does this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I will need that soon :-)