Skip to content

Config files' test prior to nginx start/reload - #147

Merged
lucasdillmann merged 2 commits into
mainfrom
config-file-test
Sep 28, 2026
Merged

lucasdillmann merged 2 commits into
mainfrom
config-file-test

Conversation

@lucasdillmann

Copy link
Copy Markdown
Owner

No description provided.

@lucasdillmann lucasdillmann self-assigned this Sep 28, 2026
@lucasdillmann
lucasdillmann marked this pull request as ready for review September 28, 2026 22:21
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

[High risk] Adds configuration validation before nginx reload.

The PR appears safe to merge based on this review.

Summary

The PR stages generated nginx configuration files and tests them before replacing the live files. It also adds path and temporary-directory tests and documents the behavior in the changelog. The change since the previous review only reformats a log call.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Generate staging files] --> B[Validate with nginx]
  B -->|Pass| C[Generate and replace live files]
  B -->|Fail| D[Keep current files]
Loading

Reviews (2) · Last reviewed commit: "Config files' test prior to nginx start/..."

Comment thread internal/business/domain/nginx/service_config_files.go
@sonarqubecloud

Copy link
Copy Markdown

Repository owner deleted a comment from greptile-apps Bot Sep 28, 2026
@lucasdillmann
lucasdillmann merged commit 108f58b into main Sep 28, 2026
5 checks passed
@lucasdillmann
lucasdillmann deleted the config-file-test branch September 28, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant