Repository navigation
Switch build system to Ninja and fix JUCE 8.0 compatibility - #1
Merged
Merged
Conversation
- Update Makefile to use Ninja generator instead of Unix Makefiles - Update README to document Ninja as a prerequisite - Add note about generator selection in build instructions
- Replace deprecated JuceHeader.h includes with individual module includes - Fix int64_t type usage (add cstdint includes) - Update AudioPluginInstance API (remove getAudioProcessor, use getParameters directly) - Fix FFT constructor calls to use Order parameter - Update FileChooser API to use launchAsync - Fix ProgressBar initialization - Fix vector contains() calls to use std::find - Add addDefaultFormats() for plugin format manager
- Fix trailing whitespace - Apply clang-format to all C++ files
- Reorder includes in MainComponent.h (JuceHeader.h before other local includes) - Reorder includes in MainWindow.h (JuceHeader.h before MainComponent.h)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the build system from Unix Makefiles to Ninja and fixes compilation errors for JUCE 8.0 compatibility.
Changes
Build System
-G Ninjawhen configuring CMakeJUCE 8.0 Compatibility Fixes
JuceHeader.hincludes with individual module includes viasrc/JuceHeader.hint64_ttype usage (addcstdintincludes where needed)AudioPluginInstanceAPI (removegetAudioProcessor(), usegetParameters()directly)OrderparameterFileChooserAPI to uselaunchAsyncinstead ofbrowseForFileToOpenProgressBarinitialization in constructorvector.contains()calls to usestd::findaddDefaultFormats()for plugin format manager instead of manual VST3 format additionBenefits
Testing