Repository navigation
Conversation
The existing Benchmark Compare workflow diffs two branches/refs but always builds each with whatever compiler the runner defaults to, so it can't isolate compiler choice. This adds a workflow_dispatch job that builds a single ref with both GCC and Clang (separate build trees so neither shares generated dependency build files) and diffs the results with benchmark's compare.py. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 16 16
Lines 937 937
Branches 416 416
=======================================
Hits 876 876
Misses 12 12
Partials 49 49 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Drop the separate new workflow in favor of reusing the existing branch-vs-branch Benchmark Compare workflow: branch B now explicitly builds with clang/clang++ (branch A keeps the runner default, gcc on Linux), so dispatching with branch_a=main, branch_b=<this branch> profiles compiler choice instead of a source diff. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lubyant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmark Compare(branch-vs-branch) workflow instead of adding a new one.CC=clang CXX=clang++(non-Windows), while branch A keeps the runner's default compiler (gcc on Linux). Dispatching withbranch_a=main,branch_b=<this branch>therefore profiles GCC vs Clang on identical source rather than a source diff.Test plan
Benchmark Compareviaworkflow_dispatchwithbranch_a=main,branch_b=ci/benchmark-compiler-compareand confirm the summary shows a GCC vs Clang diff.