[port #1063] preserve names required by the runtime in tiny mode - #5
Open
luantak wants to merge 2 commits into
Open
[port #1063] preserve names required by the runtime in tiny mode#5luantak wants to merge 2 commits into
luantak wants to merge 2 commits into
Conversation
Change "// go:linkname targets" to "// go linkname targets" so staticcheck does not treat it as a mistyped directive. Co-authored-by: Paul <luantak@pm.me>
cursor
Bot
force-pushed
the
cursor/maremagnum-pr-1063-tiny-runtime-name-safety-2676
branch
from
August 11, 2026 21:05
722d46f to
595743c
Compare
luantak
marked this pull request as ready for review
August 11, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validity: valid
Tiny mode was removing/changing names that runtime paths consume as data (reflect stubs/GC maps, value-method wrappers, sentinels, system-goroutine filtering). Keeping only the exact toolchain-required names is a safety fix, not a cosmetic one.
Upstream
burrowers#1063
Commit layout
Commit 1 is Maremagnum's from burrowers#1063 (author preserved as on the upstream commit:
autoprofiler <autoprofiler@local.invalid>); following commit(s) address luantak/mvdan review feedback and are authored by the Cursor/luantak port side.691ccf9 autoprofiler | preserve names required by the runtime in tiny mode595743c Cursor Agent | Address review feedback: fix staticcheck go:linkname commentWhat this ports
toolchain_name_dependencies.goallowlist0004-preserve-tiny-runtime-names.patchreflect-runtime-names.txtarFeedback applied
// go:linkname targetsto// go linkname targetsso staticcheck does not treat it as a mistyped directiveTesting
go test -run 'TestScript/(reflect-runtime-names|tiny|reflect)$' .✅Remaining risks
Notes for Paul
High value for tiny correctness; review allowlist carefully before forwarding.