[port #1064] preserve runtime SetTraceback behavior in tiny mode - #4
Open
luantak wants to merge 2 commits into
Open
[port #1064] preserve runtime SetTraceback behavior in tiny mode#4luantak wants to merge 2 commits into
luantak wants to merge 2 commits into
Conversation
Co-authored-by: Paul <luantak@pm.me>
luantak asked for a clearer explanation: emptying setTraceback breaks Windows WER via SEM_NOGPFAULTERRORBOX. Expand tiny-wer.txtar and runtime_patch comments; use go 1.23 in the script go.mod like other tests. Rebased to keep master's writeErrStr strip. Co-authored-by: Paul <luantak@pm.me>
cursor
Bot
force-pushed
the
cursor/maremagnum-pr-1064-tiny-settraceback-2676
branch
from
August 11, 2026 21:05
a29f070 to
7b2f2d6
Compare
luantak
marked this pull request as ready for review
August 11, 2026 23:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validity: valid
Why emptying
setTracebackbreaks Windows (luantak: “explain this more”)Tiny mode is meant to strip traceback printing.
runtime.setTracebackalso updates process-wide state that is not about printing:debug.SetTraceback("wer")clearsSEM_NOGPFAULTERRORBOXviaSetErrorMode.setTraceback's body,SetTraceback("wer")becomes a no-op: WER stays suppressed even though the app asked to enable it.So this change keeps traceback-output cleanup elsewhere, but stops emptying
setTracebackso non-printing semantics still work.testdata/script/tiny-wer.txtarasserts the SEM flag flips on Windows.Upstream
burrowers#1064 (was dirty vs master)
Commit layout
Commit 1 is Maremagnum's from burrowers#1064 (author preserved as on the upstream commit:
autoprofiler <autoprofiler@local.invalid>); following commit(s) address luantak/mvdan review feedback and are authored by the Cursor/luantak port side.f9f97c2 autoprofiler | preserve runtime SetTraceback behavior in tiny mode7b2f2d6 Cursor Agent | Address review feedback: explain WER semantics; go 1.23 in scriptWhat this ports
setTracebackbody-emptying casetiny-wer.txtar(kept)Feedback applied
writeErrStrtiny suppression; only droppedsetTracebackstrippingruntime_patchcomments with the WER /SEM_NOGPFAULTERRORBOXexplanation abovego.modusesgo 1.23for consistency with other script tests (Copilot)Testing
go test -run 'TestScript/(tiny|tiny-wer)$' .✅ (WER script skips on non-Windows)Remaining risks
[!windows] skip).Notes for Paul
Clean rebase; good to forward after a Windows CI glance.