MD-2297: Fix block_panopto and block_ues_people breaking PHPUnit init - #23
Open
dvdcastro wants to merge 194 commits into
Open
MD-2297: Fix block_panopto and block_ues_people breaking PHPUnit init#23dvdcastro wants to merge 194 commits into
dvdcastro wants to merge 194 commits into
Conversation
…ect grade report for constructor
… and missing userinfo
Update Staging
Co-authored-by: Cursor <cursoragent@cursor.com>
… (moodle/site:viewuseridentity)
MD-1761 - Show user workday UID on profile
Initial add of checksummer
Moodle 405 main
Moodle 405 main
block_panopto/classes/external/get_content.php required externallib.php which calls require_phpunit_isolation() at the top level, crashing PHPUnit DB init. Replaced with core_external namespace imports (Moodle 4.5 canonical approach). block_ues_people declared pluginname='LSU People' which duplicated block_lsu_people and triggered plugin_defective_exception during init. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_content.phprequiredexternallib.phpwhich callsrequire_phpunit_isolation()at include-time, crashing PHPUnit DB init. Replaced therequire_onceand bareusealiases withcore_external\*namespace imports (Moodle 4.5 canonical approach).pluginnamewas'LSU People', duplicatingblock_lsu_peopleand triggeringplugin_defective_exceptionduring PHPUnit init. Renamed to'LSU People (UES)'to make it unique.Acceptance Criteria
block_panoptoexternal class usescore_externalnamespace imports instead of requiringexternallib.phpblock_ues_peoplepluginname is unique (LSU People (UES))Jira
MD-2297
Test Plan
php admin/tool/phpunit/cli/init.php— should complete without errors🤖 Generated with Claude Code